Include plate acquisition start time even if end time is missing#666
Open
melissalinkert wants to merge 1 commit intoome:masterfrom
Open
Include plate acquisition start time even if end time is missing#666melissalinkert wants to merge 1 commit intoome:masterfrom
melissalinkert wants to merge 1 commit intoome:masterfrom
Conversation
Member
|
This seems to be working fine (once I'd worked out that the ome.xml sample above has the Acquisition name set to Before this PR: 
With this PR: 
|
will-moore
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds an extra case to the logic for setting the plate acquisition
name in the tree in the left-hand panel. If a start time (but not an
end time) was set, then the name will be the start time instead of Run $id.
To test, import plate-acquisition-test.ome.xml, which is a simple single-well plate with no
EndTimeon thePlateAcquisition. Verify that thestarttimeonplateacquisitionis set to a valid timestamp in the database. Open the same plate in OMERO.web without this change, and verify that the corresponding plate acquisition is listed in the left-hand panel tree asRunfollowed by the ID number. With this change, open the plate again (no need to reimport) and verify that the plate acquisition is now listed as a timestamp matching the value ofstarttime.